swtpm_setup: Comment flags for storage primary key and deprecate --cr… #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate-spk Comment the flags used for creating the storage primary key. Deprecate the --create-spk option since it may create an RSA-3072 key and it creates a NIST P384 instead of NIST P256, both of which users may not expect and know how to use. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eate-spk
Comment the flags used for creating the storage primary key. Deprecate the --create-spk option since it may create an RSA-3072 key and it creates a NIST P384 instead of NIST P256, both of which users may not expect and know how to use.