Merge pull request #38 from phakpoom/master

Change config prototype under parameters to variable (fixed #39)
stefandoorn · Feb 25, 2018 · 48b2329 · 48b2329
2 parents 82b521a + 0ec7051
commit 48b2329
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 1 deletion.
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -68,7 +68,7 @@ private function addSitemapSection(ArrayNodeDefinition $node): void
                                 ->cannotBeEmpty()
                             ->end()
                             ->arrayNode('parameters')
-                                ->prototype('array')->end()
+                                ->prototype('variable')->end()
                                 ->info('Add optional parameters to the route.')
                             ->end()
                             ->arrayNode('locales')

diff --git a/tests/Application/app/config/config.yml b/tests/Application/app/config/config.yml
@@ -12,6 +12,10 @@ imports:
 
     - { resource: "../../../../vendor/sylius/sylius/app/config/security.yml" }
 
+sitemap:
+    static_routes:
+        - { route: sylius_shop_order_show, parameters: { tokenValue: fooToken } }
+
 framework:
     translator: { fallbacks: ["%locale%"] }
     secret: "%secret"

diff --git a/tests/Responses/Expected/show_sitemap_all.xml b/tests/Responses/Expected/show_sitemap_all.xml
@@ -39,4 +39,18 @@
     <changefreq>weekly</changefreq>
     <priority>0.3</priority>
   </url>
+  <url>
+    <loc>http://localhost/en_US/order/fooToken</loc>
+    <xhtml:link rel="alternate" hreflang="en" href="http://localhost/en_US/order/fooToken"/>
+    <xhtml:link rel="alternate" hreflang="nl" href="http://localhost/nl_NL/order/fooToken"/>
+    <changefreq>weekly</changefreq>
+    <priority>0.3</priority>
+  </url>
+  <url>
+    <loc>http://localhost/nl_NL/order/fooToken</loc>
+    <xhtml:link rel="alternate" hreflang="en" href="http://localhost/en_US/order/fooToken"/>
+    <xhtml:link rel="alternate" hreflang="nl" href="http://localhost/nl_NL/order/fooToken"/>
+    <changefreq>weekly</changefreq>
+    <priority>0.3</priority>
+  </url>
 </urlset>
diff --git a/tests/Responses/Expected/show_sitemap_all_relative.xml b/tests/Responses/Expected/show_sitemap_all_relative.xml
@@ -39,4 +39,18 @@
     <changefreq>weekly</changefreq>
     <priority>0.3</priority>
   </url>
+  <url>
+    <loc>/en_US/order/fooToken</loc>
+    <xhtml:link rel="alternate" hreflang="en" href="/en_US/order/fooToken"/>
+    <xhtml:link rel="alternate" hreflang="nl" href="/nl_NL/order/fooToken"/>
+    <changefreq>weekly</changefreq>
+    <priority>0.3</priority>
+  </url>
+  <url>
+    <loc>/nl_NL/order/fooToken</loc>
+    <xhtml:link rel="alternate" hreflang="en" href="/en_US/order/fooToken"/>
+    <xhtml:link rel="alternate" hreflang="nl" href="/nl_NL/order/fooToken"/>
+    <changefreq>weekly</changefreq>
+    <priority>0.3</priority>
+  </url>
 </urlset>
diff --git a/tests/Responses/Expected/show_sitemap_static.xml b/tests/Responses/Expected/show_sitemap_static.xml
@@ -28,4 +28,18 @@
     <changefreq>weekly</changefreq>
     <priority>0.3</priority>
   </url>
+  <url>
+    <loc>http://localhost/en_US/order/fooToken</loc>
+    <xhtml:link rel="alternate" hreflang="en" href="http://localhost/en_US/order/fooToken"/>
+    <xhtml:link rel="alternate" hreflang="nl" href="http://localhost/nl_NL/order/fooToken"/>
+    <changefreq>weekly</changefreq>
+    <priority>0.3</priority>
+  </url>
+  <url>
+    <loc>http://localhost/nl_NL/order/fooToken</loc>
+    <xhtml:link rel="alternate" hreflang="en" href="http://localhost/en_US/order/fooToken"/>
+    <xhtml:link rel="alternate" hreflang="nl" href="http://localhost/nl_NL/order/fooToken"/>
+    <changefreq>weekly</changefreq>
+    <priority>0.3</priority>
+  </url>
 </urlset>