Moved the metadata into setup.cfg.
#139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for your contribution! The build fails for Python 2.7, which is still supported by |
|
Should we just drop 2.7? In my own projects I have never supported python 2. Given that I am in python since 2013 ... and given that 2 has been dropped by PSF, I guess it may make sense to drop it too. |
Added `pyproject.toml`. Version is now fetched and populated automatically from git tags using setuptools_scm. Metadata stored in source files is fetched using `read_version`. Got rid of raw scripts, using `console_scripts` entry point since now. Disabled CI for python `2.7` because of `File "tests.py", line 1069, in <module> m = __import__(module, fromlist=[module]) TypeError: Item in "from list'' must be str, not unicode`
|
I've opened the discussion about dropping Python 2.7 support at #140. |
|
I was going to make these same changes. Almost exactly like you made them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
pyproject.toml.Version is now fetched and populated automatically from git tags using
setuptools_scm.Metadata stored in source files is fetched using
read_version.Got rid of raw scripts, using
console_scriptsentry point since now.