Dependency-less version #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for your PR, and apologies for the delay in reviewing it! |
|
Excellent. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stephano-meschiari,
I like {latex2exp}, but as a basic tool possibly used in different contexts, it should limit its strong dependencies to a bare minimum. {magrittr} is really not required since code could be easily rewritten without the pipe. Also {stringr} brings other packages with him : {stringi}, {rlang}, {cli}, {lifecycle}, {vctrs}, and {glue}. While this is OK for people using the {tidyverse}, it is not for those that stick on base R.
Also note that many base functions equivalent to {stringr} ones are now faster in recent R versions.
Here, I propose a version of {latex2exp} that does not depends on {magrittr} or {stringr}. It passes all tests, produces correct
latex2exp_examples()and compiles both vignettes, appart for the bug with\pmodthat is also in the original version (and it is not the purpose of this pull request to correct existing bugs).