Add bin links #57
Merged
Add bin links #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to add test but it is not running tests on my PR |
thoov
reviewed
Feb 23, 2022
krisselden
force-pushed
the
bin-links
branch
2 times, most recently
from
f8b97c7 to
1cfb06e
Compare
|
Added a test. |
thoov
reviewed
Feb 24, 2022
| writeSync() { | ||
| console.warn('this method is deprecated, please use write instead'); |
There was a problem hiding this comment.
We should probably use your deprecated message from above which includes the exact method people should use:
project.writeSync() is now deprecated, please use `await project.write()` instead.
|
LGTM! |
krisselden
force-pushed
the
bin-links
branch
from
1cfb06e to
8bb5cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #56