#issue-19: add ability to define version and app-version of created helm package

[WojcikMM]

This should be usefull i.e. when user use 'release' publish schema.
When no value is defined then values are getted from chart.yaml ( as previously ).
This makes no breacking change in API. Only extend ablilities.

[stefanprodan]

LGTM

Thanks @WojcikMM 🥇

[stefanprodan]

hmm this breaks the action https://github.com/stefanprodan/helm-gh-pages/runs/1655510957

[WojcikMM]

Strange. It breaks on some "stat"

[stefanprodan]

Have you tested this?

package() {
  [[ -z $APP_VERSION ]] || APP_VERSION_CMD=" --app-version $APP_VERSION";
  [[ -z $CHART_VERSION ]] || CHART_VERSION_CMD=" --version $CHART_VERSION"

  helm package ${CHARTS[*]} --destination ${CHARTS_TMP_DIR} "$APP_VERSION_CMD" "$CHART_VERSION_CMD"
}

I think it needs a ;

[mwojcik-llx]

Of course i test it before i create PR. But maybe there is some older syntax supported and sure ";" could makes problem. But i am suprised

[mwojcik-llx]

@stefanprodan then this could be mark as done ? #19

[stefanprodan]

Yes feel free to close it.