-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement gRPC for echo
and version
APIs
#322
Merged
stefanprodan
merged 5 commits into
stefanprodan:master
from
JayKaku:feature/grpc-version-echo-apis
Feb 25, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c305843
restructured api to api/http, api/grpc, pkg http
JayKaku 2209735
Feature grpc version echo api (#3)
JayKaku e008d1f
Added config, logger for grpc echo api
JayKaku 8535efc
Implemented zap logger in place of log | gprc echo
JayKaku 2251bee
Fixed parsing logger in echo_test.go service registeration
JayKaku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package grpc | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/stefanprodan/podinfo/pkg/api/grpc/echo" | ||
"go.uber.org/zap" | ||
) | ||
|
||
type echoServer struct { | ||
echo.UnimplementedEchoServiceServer | ||
config *Config | ||
logger *zap.Logger | ||
} | ||
|
||
func (s *echoServer) Echo (ctx context.Context, message *echo.Message) (*echo.Message, error){ | ||
|
||
s.logger.Info("Received message body from client:", zap.String("input body", message.Body)) | ||
return &echo.Message {Body: message.Body}, nil | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
syntax = "proto3"; | ||
|
||
option go_package = "./echo"; | ||
|
||
package echo; | ||
|
||
message Message { | ||
string body = 1; | ||
} | ||
|
||
|
||
service EchoService { | ||
rpc Echo(Message) returns (Message) {} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this call Unimplemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something protoc-gen-grpc-go compiler now throws an error for in newer version
must be embedded to have forward compatible implementations.
, it act as a placeholder or a default behavior for any methods that have not yet been implemented in your code