Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics refactor #172

Conversation

jerrymhuang
Copy link
Collaborator

@jerrymhuang jerrymhuang commented Jun 5, 2024

Refactored all diagnostics modules:

  1. Created helper functions for common procedures shared by SBC-related diagnostics modules;
  2. Created a more flexible plot_distribution_2d() module for pairplots;
  3. Migrated all diagnostics modules and related utilities to experimental;
  4. Made all diagnostics modules more dependent on Keras;
  5. Add data types for all module inputs (except samples; in discussion);

Still to come:

  1. Deeper refactoring of plot_sbc_ecdf() and plot_sbc_histogram();
  2. Make module inputs compatible with nested sample dictionaries (discussion focus for above point 5);
  3. Systematic testing of all refactored modules;
  4. A user-friendly workflow.diagnose() front-end (or the like) that encapsulates the modularized design of the modules.

Any feedback or suggestions are welcome.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jerrymhuang jerrymhuang marked this pull request as draft June 5, 2024 23:17
@jerrymhuang jerrymhuang self-assigned this Jun 14, 2024
@jerrymhuang jerrymhuang added the refactoring Some code shall be redesigned label Jun 14, 2024
@LarsKue
Copy link
Collaborator

LarsKue commented Jun 24, 2024

2000+ lines in 2 commits is too much, you might have to redo this one

@marvinschmitt marvinschmitt deleted the branch stefanradev93:streamlined-backend September 23, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Some code shall be redesigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants