Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook linting errors fix #177

Conversation

Chase-Grajeda
Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda commented Jun 27, 2024

Added newline to end of breaking notebooks:

  • Covid19_Initial_Posterior_Estimation.ipynb
  • LCA_Model_Posterior_Estimation.ipynb
  • Model_Comparison_MPT.ipynb

Linter is still failing due to unfinished changes in base_approximator.py, which is out of scope for this fix

Added newline to end of breaking notebooks
@Chase-Grajeda Chase-Grajeda added the bug Something isn't working label Jun 27, 2024
@Chase-Grajeda Chase-Grajeda self-assigned this Jun 27, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Chase-Grajeda Chase-Grajeda marked this pull request as ready for review June 27, 2024 15:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.32%. Comparing base (e829619) to head (2267771).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           streamlined-backend     #177   +/-   ##
====================================================
  Coverage                66.32%   66.32%           
====================================================
  Files                       91       91           
  Lines                     1675     1675           
====================================================
  Hits                      1111     1111           
  Misses                     564      564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanradev93 stefanradev93 merged commit 3753bf1 into stefanradev93:streamlined-backend Jul 5, 2024
2 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants