Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#192 - Add multiple BusinessHours for a Resource #193

Merged
merged 4 commits into from
May 29, 2024

Conversation

spalyukh-flex
Copy link
Contributor

Usage example:

        BusinessHours businessHours1 = new BusinessHours(null, LocalTime.of(6, 0));
        BusinessHours businessHours2 = new BusinessHours(LocalTime.of(12, 0), LocalTime.of(15, 0));
        Resource resource = new Resource("id123", "Hello World", "red", null, businessHours1, businessHours2);
        calendar.addResource(resource);

Result:

image

Link: #192

Copy link
Owner

@stefanuebe stefanuebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort. I added some comments with required changes.

BR Stefan

Done:
- Changed version in POM files to SNAPSHOT
- Added getter for BusinessHours to have backwards compatibility
- Set array to null if business hours array is empty

Link: stefanuebe#192
@spalyukh-flex
Copy link
Contributor Author

@stefanuebe I have fixed your comments, please merge the PR when you have time. Thanks

@stefanuebe stefanuebe self-requested a review May 29, 2024 12:36
@stefanuebe stefanuebe merged commit 7fe277f into stefanuebe:master May 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants