Create consumer hooks #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls-yroom into jesse/create-consumer-hooks
linspw
commented
May 2, 2023
| async def pre_connect(self) -> None: | ||
| user = self.scope["user"] | ||
| if not user.is_staff: | ||
| await self.close() |
There was a problem hiding this comment.
Here's a problem: how to return in the parent function to not execute the next code instructions?
|
I'm unsure about this. If you need to extend more behaviour, maybe just replacing the method and calling |
|
Hi @stefanw , the idea here is to create hooks to prevent the developer from having to overwrite/understand some implementations, it would be an "additional feature" Thinking about features, it would be something similar to Hocuspocus server Hooks, https://tiptap.dev/hocuspocus/server/hooks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR:
It's creating hooks, to avoid overwriting all hook actions and thus not wanting to overwrite something vital for the operation.