Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Codebase to use modern PHP features using Rector #225

Merged
merged 10 commits into from
Feb 20, 2024

Conversation

stefanzweifel
Copy link
Owner

Maintenance PR that uses Rector to update the entire code base to use modern PHP features.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d9ab177) 95.54% compared to head (699fd14) 95.09%.
Report is 1 commits behind head on main.

❗ Current head 699fd14 differs from pull request most recent head 5833b29. Consider uploading reports for the commit 5833b29 to get more accurate results

Files Patch % Lines
src/Console/StatsListCommand.php 86.66% 2 Missing ⚠️
src/ClassesFinder.php 80.00% 1 Missing ⚠️
src/Classifiers/MiddlewareClassifier.php 50.00% 1 Missing ⚠️
src/Statistics/NumberOfRoutes.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #225      +/-   ##
============================================
- Coverage     95.54%   95.09%   -0.45%     
  Complexity      267      267              
============================================
  Files            44       44              
  Lines           785      714      -71     
============================================
- Hits            750      679      -71     
  Misses           35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanzweifel stefanzweifel marked this pull request as ready for review February 20, 2024 19:01
@stefanzweifel stefanzweifel merged commit 7d0db07 into main Feb 20, 2024
@stefanzweifel stefanzweifel deleted the refactor-with-rector branch February 20, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant