Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow async factory function on forRoot #133

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

stelescuraul
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Allow the passed factory function to be async.

Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change which does not add functionality)

Checklist:

  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@stelescuraul stelescuraul merged commit f96b187 into master Aug 8, 2022
@stelescuraul stelescuraul deleted the feat/allow-async-factory branch August 8, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant