Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[3] Upgrade horizonclient to v2 to fix horizon v1 API change in load offers #360

Closed
nikhilsaraf opened this issue Feb 7, 2020 · 3 comments
Closed

[3] Upgrade horizonclient to v2 to fix horizon v1 API change in load offers #360

nikhilsaraf opened this issue Feb 7, 2020 · 3 comments
Assignees
@nikhilsaraf
Labels
bug Something isn't working release-blocker this issue is blocking a release
Milestone
v1.8.0

Comments

@nikhilsaraf
Copy link
Contributor

Describe the bug

This is the error message I am seeing on the test network: unable to load existing offers: Can't load offers: json: cannot unmarshal string into Go struct field Offer._embedded.records.id of type int64.

This needs to work for older versions of horizon too.

Expected behavior

I think the correct behavior in this situation is for the bot to work

Frequency

The frequency is: Always on horizon v1
@nikhilsaraf nikhilsaraf added bug Something isn't working release-blocker this issue is blocking a release labels Feb 7, 2020
@nikhilsaraf nikhilsaraf added this to the v1.8.0 milestone Feb 7, 2020
@nikhilsaraf nikhilsaraf self-assigned this Feb 7, 2020
@nikhilsaraf nikhilsaraf changed the title horizon v1 API change broke kelps load offers logic [1] horizon v1 API change broke kelps load offers logic Feb 7, 2020
@ire-and-curses
Copy link

Surprised to see this because we made the types backwards compatible in the Go SDK. Could you check that you're using the latest version of the SDK? cc @abuiles

@abuiles
Copy link

abuiles commented Feb 7, 2020

@nikhilsaraf as Eric point out, version 2.0 of horizonclient offers backwards compatibility support for this, which version are you using?

@nikhilsaraf
Copy link
Contributor Author

Kelp's glide.yaml shows that it is currently using v1.3 -- I'll upgrade to v2

@nikhilsaraf nikhilsaraf changed the title [1] horizon v1 API change broke kelps load offers logic [3] Upgrade horizonclient to v2 to fix horizon v1 API change in load offers Feb 7, 2020
@nikhilsaraf nikhilsaraf mentioned this issue Feb 8, 2020
Closed
nikhilsaraf added a commit to nikhilsaraf/kelp that referenced this issue Feb 12, 2020
@nikhilsaraf
Revert "Upgrade horizonclient to v2 to fix horizon v1 API changes (cl…
b2eb3cd 
…oses stellar-deprecated#360) (stellar-deprecated#362)"

This reverts commit ba19842.
nikhilsaraf added a commit to nikhilsaraf/kelp that referenced this issue Feb 15, 2020
@nikhilsaraf
Revert "Upgrade horizonclient to v2 to fix horizon v1 API changes (cl…
ff9ce72 
…oses stellar-deprecated#360) (stellar-deprecated#362)"

This reverts commit ba19842.
nikhilsaraf added a commit to nikhilsaraf/kelp that referenced this issue Feb 16, 2020
@nikhilsaraf
Revert "Upgrade horizonclient to v2 to fix horizon v1 API changes (cl…
a509988 
…oses stellar-deprecated#360) (stellar-deprecated#362)"

This reverts commit ba19842.
nikhilsaraf added a commit that referenced this issue Feb 16, 2020
@nikhilsaraf
upgrade horizonclient to patched version to fix load offers issues (c…
c0a4e3a 
…loses #369) (#373)

* Revert "Upgrade horizonclient to v2 to fix horizon v1 API changes (closes #360) (#362)"

This reverts commit ba19842.

* 2 - update glide.yaml and glide.lock file to use v2.0 of stellar/go repo for the horizonclient dependency

* 3 - use forked version of stellar/go at nikhilsaraf/go branch "horizonclient-v2.0.0/1_export_offerBase"

* 4 - upgrade to second patched version of horizonclient (fee stats fix)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

Labels
bug Something isn't working release-blocker this issue is blocking a release
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
3 participants
@abuiles @nikhilsaraf @ire-and-curses