You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
We want to add validation to the config (of type *VolumeFilterConfig in makeFilterVolume in plugins/volumeFilter.go. This validation should include checking that exactly one asset cap is non-nil; the mode is valid; and optional accountIDs and market IDs are both non-nil.
Once the above is added, a test case should be added to TestMakeFilterVolume within volumeFilter_test.go. This test case should confirm that if an invalid configuration is constructed, an error is thrown by makeFilterVolume.
The text was updated successfully, but these errors were encountered:
The requirements for this have been amended - market IDs and account IDs can be nil, and the action must be valid. So we only need to validate that exactly one cap is non-nil, and the mode and action are valid.
* Initial commit
* Vary actions and modes, check mods
* Handle nil market and account IDs in other tests
* Remove mode test
* Revert nil checks for market and account ids.
* Clarify nil ids elsewhere in codebase
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We want to add validation to the config (of type
*VolumeFilterConfig
inmakeFilterVolume
inplugins/volumeFilter.go
. This validation should include checking that exactly one asset cap is non-nil; the mode is valid; and optional accountIDs and market IDs are both non-nil.Once the above is added, a test case should be added to
TestMakeFilterVolume
withinvolumeFilter_test.go
. This test case should confirm that if an invalid configuration is constructed, an error is thrown bymakeFilterVolume
.The text was updated successfully, but these errors were encountered: