Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Use horizon/protocol types #202

Merged

Conversation

poliha
Copy link
Contributor

@poliha poliha commented Jul 22, 2019

This PR covers part of the work required to update Kelp to use the new stellar Go sdk. This PR focuses on changing the types from clients/horizon to protocols/horizon.
This PR does not change all instances of clients/horizon types as there are some that is still needed by the old SDK. These will be handled in a separate PR when converting to the new horizonclient package.

@poliha poliha requested a review from nikhilsaraf as a code owner July 22, 2019 18:18
Copy link
Contributor

@nikhilsaraf nikhilsaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for fixing these up!

@poliha poliha merged commit 0f9ca89 into stellar-deprecated:hprotocol_merge_base Jul 23, 2019
@poliha poliha deleted the use_hprotocol_types branch July 23, 2019 11:11
nikhilsaraf pushed a commit that referenced this pull request Jul 25, 2019
* change horizon types

* use hprotocol
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants