Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add metrics to button (part of #508) #582

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions gui/web/src/components/atoms/Button/Button.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ class Button extends Component {
loading: false,
onClick: () => {},
disabled: false,
trackEvent: (eventName, values) => {},
eventName: '',
}

static propTypes = {
Expand All @@ -46,7 +44,6 @@ class Button extends Component {
onClick: PropTypes.func,
loading: PropTypes.bool,
disabled: PropTypes.bool,
trackEvent: PropTypes.func,
eventName: PropTypes.string,
};

Expand All @@ -55,17 +52,27 @@ class Button extends Component {
return
}

nikhilsaraf marked this conversation as resolved.
Show resolved Hide resolved
if (this.props.eventName === "" || this.props.eventName === undefined) {
return
}

var _this = this
// TODO DS populate the eventData.
this._asyncRequests["sendMetricEvent"] = sendMetricEvent(this.props.baseUrl, this.props.eventName, {}).then(resp => {
var eventData = {
nikhilsaraf marked this conversation as resolved.
Show resolved Hide resolved
'eventName': this.props.eventName,
'type': 'generic',
'component': 'button'
}
this._asyncRequests["sendMetricEvent"] = sendMetricEvent(this.props.baseUrl, this.props.eventName, eventData).then(resp => {
if (!_this._asyncRequests["sendMetricEvent"]) {
// if it has been deleted it means we don't want to process the result
return
}

delete _this._asyncRequests["sendMetricEvent"];

// TODO DS Determine how to process resp
if (resp["success"] === undefined) {
nikhilsaraf marked this conversation as resolved.
Show resolved Hide resolved
console.log(resp["error"])
}
nikhilsaraf marked this conversation as resolved.
Show resolved Hide resolved
})
}

Expand Down