Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

feat: add "4. Build an App" step to "Getting Started" #528

Merged
merged 9 commits into from
Sep 5, 2023
Merged

feat: add "4. Build an App" step to "Getting Started" #528

merged 9 commits into from
Sep 5, 2023

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Aug 2, 2023

This completes the end-to-end tour of Soroban, walking people through building a simple frontend for their two contracts using Astro and interacting with them using Freighter.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@chadoh chadoh changed the title feat: add 4. Build an App step to Getting Started feat: add "4. Build an App" step to "Getting Started" Aug 3, 2023
@chadoh
Copy link
Contributor Author

chadoh commented Aug 3, 2023

@Julian-dev28 Thanks for going through this! I've addressed all your feedback.

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@chadoh
Copy link
Contributor Author

chadoh commented Aug 3, 2023

The call to increment is currently failing with the same bug described in:

I think we need to fix this before we can merge this tutorial step. I'll mark the PR as draft so we don't get trigger-happy.

You can now play with a deployed version of the tutorial app at https://ahalabs.dev/soroban-tutorial-project/, hosted at https://github.com/AhaLabs/soroban-tutorial-project. Should we transfer ownership of this repository to the stellar org?

@chadoh chadoh marked this pull request as draft August 3, 2023 20:31
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

chadoh and others added 3 commits August 31, 2023 10:28
@chadoh
feat: add 4. Build an App step to Getting Started
c863bf2 
This completes the end-to-end tour of Soroban, walking people through
building a simple frontend for their two contracts using Astro and
interacting with them using Freighter.
@chadoh @Julian-dev28
fix: create-astro version; import; post-install
05a43f2 
Co-authored-by: Julian Martinez <julian_martinez28@outlook.com>
@chadoh @tomerweller
feat: get more explicit about non-Astro compat
929e38f 
Co-authored-by: tomerweller <tomer.weller@gmail.com>
briwylde08 and others added 4 commits August 31, 2023 10:28
@briwylde08 @chadoh
editorial nits
df3c673
@chadoh @briwylde08
clarify that we're not using a UI library here
882fc21 
Co-authored-by: Bri Wylde <92327786+briwylde08@users.noreply.github.com>
@chadoh @kalepail
fix: outdent CSS; explain scripts; mention wallet
b0cc243 
Co-authored-by: Tyler van der Hoeven <hi@tyvdh.com>
@chadoh
feat: add extra info about how to deploy
f646556 
it's not that easy
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@chadoh chadoh marked this pull request as ready for review August 31, 2023 19:13
@chadoh chadoh enabled auto-merge (squash) August 31, 2023 19:14
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

@ElliotFriend ElliotFriend self-requested a review September 5, 2023 16:35
ElliotFriend
ElliotFriend suggested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! One small change, and I think you're golden 👍🏻

docs/getting-started/create-an-app.mdx Outdated Show resolved Hide resolved
@chadoh @ElliotFriend
fix: add missing word 'generate'
bd45d09 
Co-authored-by: Elliot Voris <elliot@voris.me>
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr528.previews.kube001.services.stellar-ops.com/

ElliotFriend
ElliotFriend approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for this excellent and incredibly useful piece!

@chadoh chadoh merged commit 405da77 into stellar-deprecated:main Sep 5, 2023
1 check passed
@chadoh chadoh deleted the feat/build-an-app branch September 6, 2023 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briwylde08 briwylde08 briwylde08 left review comments

@Julian-dev28 Julian-dev28 Julian-dev28 left review comments

@kalepail kalepail kalepail left review comments

@willemneal willemneal willemneal left review comments

@ElliotFriend ElliotFriend ElliotFriend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chadoh @stellar-jenkins @willemneal @ElliotFriend @kalepail @Julian-dev28 @briwylde08