Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Update event docs to mention system events #535

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Aug 4, 2023

No description provided.

@sisuresh sisuresh requested a review from kalepail August 4, 2023 23:25
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Copy link
Contributor

@kalepail kalepail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this saying that diagnostic events also include contract events? So if you're retrieving contract and diagnostic events you'll see dupes?

Copy link
Contributor

@kalepail kalepail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sisuresh
Copy link
Contributor Author

sisuresh commented Aug 7, 2023

Is this saying that diagnostic events also include contract events? So if you're retrieving contract and diagnostic events you'll see dupes?

Yeah that's right.

@sisuresh sisuresh merged commit dbd834a into stellar-deprecated:main Aug 7, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants