This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
A few tweaks to quick start guide to make it work #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accordeiro
commented
Jul 29, 2022
| @@ -13,7 +13,7 @@ first Soroban contract. | |||
| Start by creating a new Rust library using the `cargo new` command. | |||
|
|
|||
| ```sh | |||
| cargo new --lib [project-name] | |||
| cargo new --lib first-project | |||
There was a problem hiding this comment.
This originally said [project-name] but later on in the config the project is referenced as "first-project" .
It's not a big deal but it took me a minute to realize I had to find and replace all first-project instances with the name I came up with for my test project.
If we make this change the whole page can be followed as a tutorial. I think anyone can figure this name can be replaced with whatever they want.
docs/getting-started/quick-start.mdx
Outdated
| Install the `wasm32-unknown-unknown` target on your machine: | ||
|
|
||
| ```sh | ||
| rustup target add wasm32-unknown-unknown |
There was a problem hiding this comment.
Can you add this step in the Setup page? I think we should make it part of the setup, rather than this step.
Comment on lines
+158
to
+160
| --wasm target/wasm32-unknown-unknown/release/first-project.wasm \ | ||
| --id 1 \ | ||
| --fn hello \ |
sisuresh
reviewed
Jul 29, 2022
leighmcculloch
approved these changes
Jul 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just went over this guide end to end with a clean rust install, these are the issues I identified along the way – hope this is helpful.