This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
docs: Written content for the liquidity pool advanced tutorial #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some minor markdown nitpicks/fixes in this file, as well as the fuzzing example tutorial
|
Preview is available here: |
|
|
||
| ``` | ||
| ```bash | ||
| cd fuzzing | ||
| cargo +nightly fuzz run fuzz_target_1 |
There was a problem hiding this comment.
Tried running this step and hit the following error
= note: 0 0x10279471c __assert_rtn + 140
1 0x10271eeec ld::passes::inits::doPass(Options&, ld::Internal&) + 1436
2 0x1025d0ef8 main + 676
A linker snapshot was created at:
/tmp/libsoroban_fuzzing_contract.dylib-2023-08-21-202249.ld-snapshot
ld: Assertion failed: (index < orderedInitOffsetAtoms.size()), function doPass, file inits.cpp, line 131.
clang: error: linker command failed with exit code 1 (use -v to see invocation)
error: could not compile `soroban-fuzzing-contract` (lib) due to previous error
Error: failed to build fuzz script: ASAN_OPTIONS="detect_odr_violation=0" RUSTFLAGS="-Cpasses=sancov-module -Cllvm-args=-sanitizer-coverage-level=4 -Cllvm-args=-sanitizer-coverage-inline-8bit-counters -Cllvm-args=-sanitizer-coverage-pc-table -Cllvm-args=-sanitizer-coverage-trace-compares --cfg fuzzing -Clink-dead-code -Zsanitizer=address -Cdebug-assertions -C codegen-units=1" "cargo" "build" "--manifest-path" "/Users/julianmartinez/Documents/GitHub/soroban-examples/soroban-examples/fuzzing/fuzz/Cargo.toml" "--target" "aarch64-apple-darwin" "--release" "--bin" "fuzz_target_1"
There was a problem hiding this comment.
I've begun working on the timelock example, so I'll dive a bit deeper into the fuzzing example, as well, since they're related. I'll save all that for another PR, though
|
Preview is available here: |
…lp-tutorial-content
|
Preview is available here: |
briwylde08
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LP tutorial currently just points to the example contract codebase, and provides no additional content/context for what is happening within the contract.
This change adds content in the form of a written guide that describes what is happening in the example contract and a few additional pieces of context/information that could be useful/helpful for developers as they write their own contracts.
A couple minor additional changes in this PR:
TUTORIAL-TEMPLATE.mdxfile that can be copied/pasted for new tutorial guides