Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Update setup instructions. #761

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Update setup instructions. #761

merged 1 commit into from
Mar 25, 2024

Conversation

fnando
Copy link
Contributor

@fnando fnando commented Mar 4, 2024

No description provided.

@stellar-jenkins
Copy link

@ElliotFriend
Copy link
Contributor

@elizabethengelman I know you've got some pending updates in the getting-started guide in #730. Can you take a look at this PR for any overlap/conflicts?

Copy link
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm good with merging this PR in first, and I can handle any conflicts in #730. It should be very few!

:shipit:

This uses [command expansion](https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html), which only works with bash-compatible shells. If you are using Windows or some other shell, you will need to copy the output of `soroban config…` and paste it into the `curl` command, or figure out how command expansion works in your shell.

:::
By default, `soroban keys generate` will fund your account using [Friendbot](https://developers.stellar.org/docs/fundamentals-and-concepts/testnet-and-pubnet#friendbot). If you don't want this behavior, run this command with `--no-fund`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

curl "https://friendbot.stellar.org/?addr=$(soroban keys address alice)"
```

:::tip Command Expansion `$(…)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an fyi - in #730 i moved this command expansion tip over to docs/getting-started/deploy-to-testnet.mdx since we reference this on that page as well

@fnando
Copy link
Contributor Author

fnando commented Mar 5, 2024

looks like soroban keys generate doesn't work on Windows, so I think we'd need to figure that out first.

@willemneal what's the reasoning behind returning an error on Windows here? https://github.com/stellar/soroban-cli/blob/187e98ccbd8c78b1da09b63b4533d1219877f4c5/cmd/soroban-cli/src/commands/network/mod.rs#L200

@stellar-jenkins
Copy link

@fnando fnando merged commit 25dfda3 into stellar-deprecated:main Mar 25, 2024
2 checks passed
@fnando fnando deleted the setup-instructions branch March 25, 2024 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants