-
Notifications
You must be signed in to change notification settings - Fork 81
Conversation
Preview is available here: |
@elizabethengelman I know you've got some pending updates in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'm good with merging this PR in first, and I can handle any conflicts in #730. It should be very few!
This uses [command expansion](https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html), which only works with bash-compatible shells. If you are using Windows or some other shell, you will need to copy the output of `soroban config…` and paste it into the `curl` command, or figure out how command expansion works in your shell. | ||
|
||
::: | ||
By default, `soroban keys generate` will fund your account using [Friendbot](https://developers.stellar.org/docs/fundamentals-and-concepts/testnet-and-pubnet#friendbot). If you don't want this behavior, run this command with `--no-fund`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
docs/getting-started/setup.mdx
Outdated
curl "https://friendbot.stellar.org/?addr=$(soroban keys address alice)" | ||
``` | ||
|
||
:::tip Command Expansion `$(…)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an fyi - in #730 i moved this command expansion tip over to docs/getting-started/deploy-to-testnet.mdx
since we reference this on that page as well
looks like @willemneal what's the reasoning behind returning an error on Windows here? https://github.com/stellar/soroban-cli/blob/187e98ccbd8c78b1da09b63b4533d1219877f4c5/cmd/soroban-cli/src/commands/network/mod.rs#L200 |
Preview is available here: |
No description provided.