-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon: Change NewSeq attribute in SequenceBumped to be a string. #1604
Merged
abuiles
merged 7 commits into
release-horizon-v0.20.0
from
fix-data-type-for-new-seq-sequence-bump
Aug 19, 2019
Merged
services/horizon: Change NewSeq attribute in SequenceBumped to be a string. #1604
abuiles
merged 7 commits into
release-horizon-v0.20.0
from
fix-data-type-for-new-seq-sequence-bump
Aug 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
changed the title
services/horizon: Change
services/horizon: Change NewSeq attribute in SequenceBumped to be a string.
Aug 17, 2019
NewSeq
attribute in SequenceBumped to be of type string.
abuiles
force-pushed
the
fix-data-type-for-new-seq-sequence-bump
branch
from
August 17, 2019 23:52
ec0e31a
to
3d41bde
Compare
abuiles
changed the base branch from
release-horizonclient-v2.0.0
to
release-horizon-v0.20.0
August 17, 2019 23:53
abuiles
requested review from
ire-and-curses,
tamirms and
bartekn
and removed request for
ire-and-curses
August 17, 2019 23:53
abuiles
force-pushed
the
fix-data-type-for-new-seq-sequence-bump
branch
from
August 17, 2019 23:57
3d41bde
to
6d635c3
Compare
abuiles
commented
Aug 18, 2019
tamirms
approved these changes
Aug 19, 2019
bartekn
approved these changes
Aug 19, 2019
This give us a struct to represent the `SequenceBumped` effect at the database layer, separating it from the horizon representation.
abuiles
force-pushed
the
fix-data-type-for-new-seq-sequence-bump
branch
from
August 19, 2019 16:37
0fa9e63
to
b070904
Compare
@bartekn I addressed your comments, thanks! |
bartekn
approved these changes
Aug 19, 2019
This was referenced Aug 19, 2019
Update data type for new_seq in BumpSequence effect to be of type String.
stellar/js-stellar-sdk#414
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Summary
Change data type for field
NewSeq
inSequenceBumped
effect fromint64
tostring.
Fixes #1363.Goal and scope
Update horizon's
JSON
response for fieldnew_seq
inNewSequenceBumped
effect to return astring
instead of anint64
. Using anint64
produces inconsistent results for clients usingJavaScript
since someint64
numbers cannot be represented as JavaScript numbers.Summary of changes
SequenceBumped
at the database (history
) level.effects
resource adapter to use the new struct when parsing thejsonb
in effects and then pass the value as a string to the horizon representation of effect.Known limitations & issues
This will likely break clients who are expecting an
int64
instead of astring
.What shouldn't be reviewed
N/A