Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/horizon: Display memo_bytes even when memo text is an empty string #2504

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Apr 23, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

This PR fixes a problem similar to #149: memo_bytes was not present in transaction response for empty string memo.

@bartekn bartekn requested a review from tamirms April 23, 2020 15:11
@cla-bot cla-bot bot added the cla: yes label Apr 23, 2020
@bartekn bartekn changed the title protocols/horizon: Display memo_bytes even when memo text is empty protocols/horizon: Display memo_bytes even when memo text is an empty string Apr 23, 2020
@bartekn bartekn merged commit 803c7e3 into stellar:release-horizon-v1.2.0 Apr 23, 2020
@bartekn bartekn deleted the memo-bytes-empty-text branch April 23, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants