Timebounds On Transactions #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
suggested changes
Mar 15, 2018
There was a problem hiding this comment.
Please see comments (small issues). Then please sign the Contributor License Agreement. Thanks for the contribution!
build/main.go
Outdated
| @@ -217,6 +217,11 @@ type Thresholds struct { | |||
| High *uint32 | |||
| } | |||
|
|
|||
| type Timebounds struct { | |||
| Mintime uint64 | |||
| Maxtime uint64 | |||
There was a problem hiding this comment.
Super small thing but can we make it MinTime and MaxTime (capital letters)?
build/transaction_test.go
Outdated
| It("succeeds", func() { Expect(err).NotTo(HaveOccurred()) }) | ||
| It("sets an minimum and maximum timebound on the transaction", func() { | ||
| Expect(subject.TX.TimeBounds.MinTime).To(BeEquivalentTo(xdr.Uint64(1521056118))) | ||
| Expect(subject.TX.TimeBounds.MaxTime).To(BeEquivalentTo(xdr.Uint64(1521056298))) |
There was a problem hiding this comment.
Any reason why not use Equal instead of BeEquivalentTo? We don't need conversions here.
Like Equal, BeEquivalentTo uses reflect.DeepEqual to compare ACTUAL with EXPECTED. Unlike Equal, however, BeEquivalentTo will first convert ACTUAL’s type to that of EXPECTED before making the comparison with reflect.DeepEqual.
|
@bartekn Hi, I've updated it based on your feedback and signed the Contributor License Agreement |
bartekn
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the following issue: #350
Basically, passing a lower and upper timebounds on a Transaction in
buildpackage.