support/contractevents: Properly parse asset topic, add event generator. #4808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR has three components:
<code>:<issuer>
format, whereas they're actually encoded as raw XDR separated by a:
byteGenerateEvent
function which lets external packages generate arbitrary event fixtures for testing without worrying about packing the XDR correctlyWhy
Respectively,
TestRealXdr()
proves thisaccount_credited
/debited
effects for SAC events. #4806 can benefit from creating events w/o needing to understand their structureSee stellar/rs-soroban-env#727 for recommendations on improving (1).
Known limitations
n/a