-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest/ledgerbackend: Update captive-core config with new BucketlistDB parameters #5333
ingest/ledgerbackend: Update captive-core config with new BucketlistDB parameters #5333
Conversation
69597b1
to
2a4e60d
Compare
24525e6
to
bba243e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, left minor comments for consideration.
cc6712c
to
827c6b0
Compare
since |
827c6b0
to
1c64e10
Compare
Co-authored-by: shawn <sreuland@users.noreply.github.com>
1c64e10
to
98f8b97
Compare
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Adds the new stellar-core BucketListDB related config parameter DEPRECATED_SQL_LEDGER_STATE. It also addresses the EXPERIMENTAL_BUCKETLIST_DB parameter, which will be completely removed in the next Stellar-core release, making DEPRECATED_SQL_LEDGER_STATE mandatory.
Horizon currently has a an option called CAPTIVE_CORE_USE_DB (to be deprecated) to use captive-core in in-memory mode. The default value of DEPRECATED_SQL_LEDGER_STATE is determined based on this flag: true for in-memory mode and false for the on-disk (preferred) mode. This check will not be necessary once the CAPTIVE_CORE_USE_DB flag is fully removed.
It also updates the parameter names: EXPERIMENTAL_BUCKETLIST_DB_INDEX_PAGE_SIZE_EXPONENT to BUCKETLIST_DB_INDEX_PAGE_SIZE_EXPONENT and EXPERIMENTAL_BUCKETLIST_DB_INDEX_CUTOFF to BUCKETLIST_DB_INDEX_CUTOFF
This should not be merged until protocol 21 has been voted on and everyone has had the chance to update to stellar-core 21.
Why
Addresses #5295
Known limitations
This PR completely removes the EXPERIMENTAL_BUCKETLIST_DB flag, which we currently use in our deployment. This means we will need to update our deployment scripts as part of the releasing this change.