Feature flag to allow null ledger data in responses #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilsaraf
previously approved these changes
Sep 19, 2018
bartekn
force-pushed
the
allow-empty-ledger-data-responses-feature-flag
branch
from
c039576
to
774e1bc
Compare
nikhilsaraf
approved these changes
Sep 19, 2018
|
Had to rebase because of the conflict. Thanks for 2nd 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quickfix for #650 (and #538, #649). It introduces a new feature flag
ALLOW_EMPTY_LEDGER_DATA_RESPONSES(default:false). When set totrueit renders unavailable ledger data (likeclose_time) asnullinstead of sending500 Internal Server Errorresponse. This is not a breaking change as the default value isfalse. It can be released in 0.14.1 patch release.