Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deployment CI that uploads the jar to the GitHub release #452

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

marcelosalloum
Copy link
Contributor

@marcelosalloum marcelosalloum commented Aug 8, 2022

What

Fix the deployment CI that uploads the jar to the GitHub release by updating the image version of cibuilds/github from 0.10 to 0.13.

Why

Close #449.

In an attempt to fix the deploy job, that's failing at:
https://github.com/stellar/java-stellar-sdk/blob/b2a93410a39f7b39f4dbb8e462214ae119a3996b/.circleci/config.yml#L20-L29

With the error message:

Failed to upload one of assets: one of the goroutines failed: failed to upload asset: /root/project/build/libs/stellar-sdk.jar: failed to upload release asset: /root/project/build/libs/stellar-sdk.jar: stat /root/project/build/libs/stellar-sdk.jar: use of closed file

Example of a failed deploy: deploy (669)

This error seems to have been fixed at tcnksm/ghr#99 and released in version 0.11.0. Also referenced in tcnksm/ghr#90.

@marcelosalloum marcelosalloum self-assigned this Aug 8, 2022
@marcelosalloum marcelosalloum changed the title Update image version of cibuilds/github from 0.10 to 0.13 Attempt to fix the deploy CI that uploads the jar to the Github release Aug 8, 2022
@marcelosalloum marcelosalloum changed the title Attempt to fix the deploy CI that uploads the jar to the Github release Fix the deployment CI that uploads the jar to the GitHub release Aug 8, 2022
@marcelosalloum marcelosalloum marked this pull request as ready for review August 8, 2022 17:21
Copy link
Contributor

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@marcelosalloum marcelosalloum merged commit 417a84b into master Aug 8, 2022
@marcelosalloum marcelosalloum deleted the fix-release-jar-deploy branch August 9, 2022 22:31
marcelosalloum added a commit that referenced this pull request Aug 11, 2022
…453)

### What

Fix the deployment CI that uploads the jar to the GitHub release by updating the software being used from https://github.com/tcnksm/ghr to https://github.com/github-release/github-release.

### Why

Close #449.

In an attempt to fix the deploy job, that's failing at:
https://github.com/stellar/java-stellar-sdk/blob/417a84bd760321dba1ded0db0b9a32455737424f/.circleci/config.yml#L20-L29

With the error message:
```text
Failed to upload one of assets: one of the goroutines failed: failed to upload asset: /root/project/build/libs/stellar-sdk.jar: failed to upload release asset: /root/project/build/libs/stellar-sdk.jar: Post https://uploads.github.com/repos/stellar/java-stellar-sdk/releases/73913299/assets?name=stellar-sdk.jar: http2: Transport: cannot retry err [stream error: stream ID 5; REFUSED_STREAM] after Request.Body was written; define Request.GetBody to avoid this error
```

Example of a failed deploy: [deploy (678)](https://app.circleci.com/pipelines/github/stellar/java-stellar-sdk/545/workflows/85aac5f6-5744-4716-83cd-5e0ee60032ce/jobs/678)

There was already an attempt to solve this in #452 without success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Release tagging not publishing artifacts to GH release page
2 participants