Fix to open file in a retry loop #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#90 This issue may relate to this PR |
|
Thanks! |
Closed
marcelosalloum
added a commit
to lightsail-network/java-stellar-sdk
that referenced
this pull request
Aug 8, 2022
### What Fix the deployment CI that uploads the jar to the GitHub release by updating the image version of cibuilds/github from `0.10` to `0.13`. ### Why Close #449. In an attempt to fix the deploy job, that's failing at: https://github.com/stellar/java-stellar-sdk/blob/b2a93410a39f7b39f4dbb8e462214ae119a3996b/.circleci/config.yml#L20-L29 With the error message: ```text Failed to upload one of assets: one of the goroutines failed: failed to upload asset: /root/project/build/libs/stellar-sdk.jar: failed to upload release asset: /root/project/build/libs/stellar-sdk.jar: stat /root/project/build/libs/stellar-sdk.jar: use of closed file ``` Example of a failed deploy: [deploy (669)](https://app.circleci.com/pipelines/github/stellar/java-stellar-sdk/539/workflows/de14000a-07fe-481c-8707-787d3f58bd48/jobs/669/steps) This error seems to have been fixed at tcnksm/ghr#99 and released in version `0.11.0`. Also referenced in tcnksm/ghr#90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project (called ghbr), when I run the command below,
I encountered the following error.
The real problem was, that the target repository (shuheiktgw/ghbr) already have a release tagged as
v0.0.5and UploadReleasedAsset failed with422 Validation Failed.However, currently the file is opened outside of a retry loop and if GitHub API request fails, the retry fails since the file is already read in UploadReleasedAsset once.
So I fixed to open the file in a retry loop! 👍