Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of statusText error check #1001

Merged
merged 1 commit into from
Aug 13, 2024
Merged

get rid of statusText error check #1001

merged 1 commit into from
Aug 13, 2024

Conversation

cah4a
Copy link
Contributor

@cah4a cah4a commented Jul 8, 2024

The reason phrase is an optional part of the HTTP spec and could be stripped by proxies, so the best practice is not relying on it.

HTTP/2 literally doesn't have it.

closes #638

@cah4a
Copy link
Contributor Author

cah4a commented Aug 1, 2024

Guys, could we have this merged?

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked into this a little bit, not certain about it but the ?? backups seem good 👍

@Shaptic Shaptic merged commit e4dd603 into stellar:master Aug 13, 2024
10 checks passed
@Shaptic Shaptic mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cast of network request failure to error fails on react-native (Android)
2 participants