Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Add support for getTransactions endpoint #1037

Merged
merged 12 commits into from
Sep 13, 2024

Conversation

aditya1702
Copy link
Contributor

No description provided.

@aditya1702 aditya1702 marked this pull request as ready for review August 26, 2024 20:36
@aditya1702 aditya1702 requested a review from Shaptic August 26, 2024 20:36
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coupla suggestions on keeping the codebase clean! You also need a yarn run _prettier run as far as I can tell.

src/rpc/api.ts Outdated Show resolved Hide resolved
src/rpc/parsers.ts Outdated Show resolved Hide resolved
src/rpc/server.ts Show resolved Hide resolved
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 👏 mind adding a CHANGELOG entry?

@aditya1702 aditya1702 merged commit e6cda07 into stellar:master Sep 13, 2024
10 checks passed
@Shaptic Shaptic mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants