Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch metadata via RPC instead of relying on the Friendbot response #1107

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 14, 2024

When SKIP_TXMETA is enabled on a Horizon instance (like SDF's), the metadata isn't available in the friendbot response, either. This means we need to rely on a different source of metadata, so we fetch the transaction from RPC, instead.

@Shaptic Shaptic added the bug label Nov 14, 2024
@Shaptic Shaptic self-assigned this Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

Size Change: +25.3 kB (+0.05%)

Total Size: 49.7 MB

Filename Size Change
dist/stellar-sdk-minimal.js 6.85 MB +4.25 kB (+0.06%)
dist/stellar-sdk-minimal.min.js 5.34 MB +2.09 kB (+0.04%)
dist/stellar-sdk-no-axios.js 6.85 MB +4.25 kB (+0.06%)
dist/stellar-sdk-no-axios.min.js 5.34 MB +2.09 kB (+0.04%)
dist/stellar-sdk-no-eventsource.js 7.11 MB +4.25 kB (+0.06%)
dist/stellar-sdk-no-eventsource.min.js 5.55 MB +2.09 kB (+0.04%)
dist/stellar-sdk.js 7.11 MB +4.25 kB (+0.06%)
dist/stellar-sdk.min.js 5.55 MB +2.09 kB (+0.04%)

compressed-size-action

@Shaptic Shaptic merged commit 3304995 into master Nov 27, 2024
11 checks passed
@Shaptic Shaptic deleted the fix-friendbot-testnet branch November 27, 2024 19:59
@Shaptic Shaptic mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants