Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fee_charged an max_fee to TransactionResponse interface. #455

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Add fee_charged an max_fee to TransactionResponse interface. #455

merged 1 commit into from
Nov 12, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Nov 11, 2019 •
edited
Loading

Document fee_charged and max_fee which were added in Horizon 0.18.0. This fields should be used instead of max_fee which will be deprecated in Horizon 0.25.0

This is the first step before #450

@abuiles abuiles merged commit 3740ea0 into master Nov 12, 2019
@abuiles abuiles deleted the max-fee-max-charged branch November 12, 2019 17:04
@abuiles abuiles mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeesunikim jeesunikim jeesunikim approved these changes

@vcarl vcarl vcarl approved these changes

@morleyzhi morleyzhi Awaiting requested review from morleyzhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abuiles @vcarl @jeesunikim