Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Server#paths. #525

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Apr 21, 2020

People should use Server#strictReceivePaths

@abuiles abuiles merged commit 50b8c1e into release-v5.0.0 Apr 21, 2020
@abuiles abuiles deleted the remove-server-paths branch April 21, 2020 21:49
@abuiles abuiles mentioned this pull request Apr 27, 2020
abuiles added a commit that referenced this pull request Apr 27, 2020
### Add
- Add fee bump related attributes to `TransactionResponse` ([#532](#532)): 
    - `fee_account: string`.
    - `fee_bump_transaction: FeeBumpTransactionResponse`:
      ```js
      interface FeeBumpTransactionResponse {
        hash: string;
        signatures: string[];
      }
      ```
    - `inner_transaction: InnerTransactionResponse`: 
      ```js
      interface InnerTransactionResponse {
        hash: string;
        signatures: string[];
        max_fee: string;
      }
      ```
- Add `memo_bytes: string` to `TransactionResponse` ([#532](#532)).
- Add `authorize_to_maintain_liabilities: boolean` to `AllowTrustOperation` ([#532](#532)).
- Add `is_authorized_to_maintain_liabilities: boolean` to `BalanceLineNative` ([#532](#532)).
- Add new result codes to `TransactionFailedResultCodes` ([#531](#531)).
  ```js
  TX_FEE_BUMP_INNER_SUCCESS = "tx_fee_bump_inner_success",
  TX_FEE_BUMP_INNER_FAILED = "tx_fee_bump_inner_failed",
  TX_NOT_SUPPORTED = "tx_not_supported",
  TX_SUCCESS = "tx_success",
  TX_TOO_EARLY = "tx_too_early",
  TX_TOO_LATE = "tx_too_late",
  TX_MISSING_OPERATION = "tx_missing_operation",
  TX_INSUFFICIENT_BALANCE = "tx_insufficient_balance",
  TX_NO_SOURCE_ACCOUNT = "tx_no_source_account",
  TX_INSUFFICIENT_FEE = "tx_insufficient_fee",
  TX_INTERNAL_ERROR = "tx_internal_error",
  ```

### Breaking changes 
- The attributes `max_fee` and `fee_charged` in `TransactionResponse` can be now a `number` or a `string`. 
  Update your code to handle both types since Horizon will start sending `string` in version `1.3.0` ([#528](#528)).
- Bump `stellar-base` to `v3.0.0`: This new version of stellar-base brings support for protocol 13, including multiple breaking changes which might affect your code, please review the list of breaking changes in [stellar-base@3.0.0](https://github.com/stellar/js-stellar-base/releases/tag/v3.0.0) release ([#524](#524)).
- Make `networkPassphrase` a required argument in `Utils.buildChallengeTx` and  `Utils.readChallengeTx` ([#524](#524)).
- Remove `Server.paths` ([#525](#525)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant