Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (SEP-10) value of the first op should not be null. #591

Merged
merged 1 commit into from
Jan 17, 2021
Merged

fix: (SEP-10) value of the first op should not be null. #591

merged 1 commit into from
Jan 17, 2021

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Oct 29, 2020 •
edited
Loading

See #592

This PR relies on stellar/js-stellar-base#379

@overcat overcat mentioned this pull request Oct 29, 2020
Closed
@overcat overcat marked this pull request as ready for review October 29, 2020 13:21
@overcat overcat mentioned this pull request Nov 10, 2020
Merged
JakeUrban
JakeUrban approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as operation.value can never be null. If thats a possibility, then the if condition should check for undefined or null.

src/utils.ts Show resolved Hide resolved
test/unit/utils_test.js Show resolved Hide resolved
@leighmcculloch leighmcculloch mentioned this pull request Jan 16, 2021
Merged
@JakeUrban JakeUrban merged commit 052266a into stellar:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeUrban JakeUrban JakeUrban approved these changes

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@overcat @leighmcculloch @JakeUrban