Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for /assets and /claimable_balances/*/(operations|transactions) endpoints #628

Merged
merged 5 commits into from
Apr 15, 2021

Conversation

paulbellamy
Copy link
Contributor

SDK updates for horizon 2.1.0, and pending 2.2.0 changes.
Matches: stellar/new-docs#373

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid and straightforward, but can you add test cases to test/unit/server/claimable_balances.js? And also update the "Unreleased" section of the CHANGELOG accordingly 👍

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check that the CodeQL scan about regexes can be ignored (or fixed), but otherwise LGTM! 👍

@paulbellamy paulbellamy merged commit de24cf5 into stellar:master Apr 15, 2021
@paulbellamy paulbellamy deleted the assets-updates branch April 15, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants