Issue #299: Types provided for effects, with Go Package being the ref…

[RabeaWahab]

• Types provided for effects, with Go Package being the reference.
• Moving Asset, Trade and Offer Types to their own files.
• Kept service_api exporting back types imported to not break anything in other files.

Any feedback is really appreciated.

Closes #299.

[Shaptic]

Thank you for this work; it's a great contribution! I just noticed some minor typos in the type definitions; please give those a look.

[Shaptic]

Awesome, looks great now! As a final touch, can you add a note (under the Unreleased heading) to the CHANGELOG summarizing this? Please follow the format of the other entries.

[Shaptic]

Last hurdle, @RabeaWahab, as you can see in the approval checklist: all of your commits need to be GPG signed! It's a bit of effort to set up, but our repository unconditionally requires that commits be signed.

Once you've configured your keys, since you already have unsigned commits, you will need to rebase & squash them all into a single, signed commit, e.g.

git rebase -i HEAD~6

The first line should be the commit right before your PR's commits. Edit the lines to say f instead of pick for all but the first commit, then save+exit to finish the rebase, and finally,

git commit --amend -S
git push -f

to sign it.

[Shaptic]

Actually, I'm going to go ahead and merge this. Be sure to set up signed commits for the future, though, this project and many others impose these kinds of requirements to trace changes and provide author authenticity.

Thank you again for your contribution! This will be part of the next release. 👍

[RabeaWahab]

Thank you @Shaptic , I will have it ready for the next PR. 🙏 again I appreciate the quick feedback from you and @paulbellamy