Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move chai-http to be a developer dependency #707

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Move chai-http to be a developer dependency #707

merged 2 commits into from
Sep 13, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Sep 10, 2021

This is only used when running tests, so we shouldn't burden downstream SDK consumers with the dependency chain.

@Shaptic Shaptic mentioned this pull request Sep 11, 2021
Merged
marcelosalloum
marcelosalloum approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shaptic Shaptic merged commit 8cae098 into master Sep 13, 2021
@Shaptic Shaptic deleted the fix-dev-deps branch September 13, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelosalloum marcelosalloum marcelosalloum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaptic @marcelosalloum