-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP-10: muxed account & memo support #709
SEP-10: muxed account & memo support #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this capability to the SDK. Two questions (❓).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't validate the SEP-10 stuff, but the JS itself LGTM! Minor notes follow.
Co-authored-by: George <Shaptic@users.noreply.github.com>
@Shaptic this isn't urgent but I wouldn't want to wait long for the js-base change. Can we make that change and any other |
Co-authored-by: George <Shaptic@users.noreply.github.com>
Updates the SEP-10 utility functions to support muxed accounts and challenge transaction memos as specified in the SEP PR
Updates
utils.buildChallengeTx()
to accept muxed accounts (M...
) for client account IDsutils.buildChallengeTx()
to accept amemo
parameter to attach to the challenge transactionutils.readChallengeTx()
to provide amemo
property in the returned objectutils.readChallengeTx()
to validate challenge transactions with muxed accounts (M...
) as the client account ID