Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-10: muxed account & memo support #709

Merged
merged 12 commits into from
Sep 15, 2021

Conversation

JakeUrban
Copy link
Contributor

@JakeUrban JakeUrban commented Sep 15, 2021

Updates the SEP-10 utility functions to support muxed accounts and challenge transaction memos as specified in the SEP PR

Updates

  • Updated utils.buildChallengeTx() to accept muxed accounts (M...) for client account IDs
  • Updated utils.buildChallengeTx() to accept a memo parameter to attach to the challenge transaction
  • Updated utils.readChallengeTx() to provide a memo property in the returned object
  • Updated utils.readChallengeTx() to validate challenge transactions with muxed accounts (M...) as the client account ID

@JakeUrban JakeUrban marked this pull request as ready for review September 15, 2021 17:41
@JakeUrban JakeUrban requested a review from Shaptic September 15, 2021 17:41
@JakeUrban JakeUrban changed the title SEP-10: muxed memo support SEP-10: muxed account & memo support Sep 15, 2021
@JakeUrban JakeUrban self-assigned this Sep 15, 2021
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this capability to the SDK. Two questions (❓).

src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't validate the SEP-10 stuff, but the JS itself LGTM! Minor notes follow.

CHANGELOG.md Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
test/unit/utils_test.js Outdated Show resolved Hide resolved
test/unit/utils_test.js Outdated Show resolved Hide resolved
test/unit/utils_test.js Outdated Show resolved Hide resolved
Co-authored-by: George <Shaptic@users.noreply.github.com>
@JakeUrban
Copy link
Contributor Author

If there's urgency to merge this before the bump to js-base, can you file an issue so this doesn't get forgotten? I'd prefer to have it use the builder

@Shaptic this isn't urgent but I wouldn't want to wait long for the js-base change. Can we make that change and any other withMuxing additions needed throughout the base project within the next week or so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants