Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client attribution to SEP-10 helpers #720

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

JakeUrban
Copy link
Contributor

resolves #668

Added client attribution matching the implementation in the Python SDK.

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward translation of the Python version, but we are of course presuming that that one behaves correctly. Can you confirm that it does what SEP-10 says it should do? I see this section in the SEP but am not 100% sure that's what we're adding here.

src/utils.ts Outdated Show resolved Hide resolved
test/unit/utils_test.js Show resolved Hide resolved
@JakeUrban
Copy link
Contributor Author

Can you confirm that it does what SEP-10 says it should do?

Its used in production for several wallet / anchor pairs and haven't heard of any issues, so I think its stable.

I see this section in the SEP but am not 100% sure that's what we're adding here.

Yea thats the right section. The idea is that SEP-10 verifies the user and anchor as account holders, but the anchor doesn't know which wallet is being used. If the wallet hosts their own stellar.toml file and signs the challenge with their SIGNING_KEY, the anchor can verify that a specific wallet is being used.

JakeUrban and others added 3 commits November 4, 2021 09:54
Co-authored-by: George <Shaptic@users.noreply.github.com>
@JakeUrban JakeUrban merged commit af77ecd into stellar:master Nov 4, 2021
@JakeUrban JakeUrban deleted the client-attribution branch November 4, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEP-10 Client Attribution Support
2 participants