Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to filter liquidity pools by participating account #727

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 16, 2021

With Horizon v2.11.0, there's a new way to filter liquidity pools: by participating account. This updates the LiquidityPoolCallBuilder to support that filter.

Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for this new filter?

@Shaptic
Copy link
Contributor Author

Shaptic commented Nov 16, 2021

Yep, done @marcelosalloum 👍

Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shaptic Shaptic merged commit 3b3ea64 into master Nov 16, 2021
@Shaptic Shaptic deleted the pools-by-account branch November 16, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants