Upgrade karma-* dependencies to their latest versions
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
force-pushed
the
upgrade-karma-suite
branch
from
b6983f6
to
cf23dd0
Compare
Shaptic
force-pushed
the
upgrade-karma-suite
branch
from
cf23dd0
to
0f6bfd9
Compare
Shaptic
requested review from
quietbits
and removed request for
marcelosalloum
quietbits
reviewed
Jan 21, 2022
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: '10.16.3' | ||
| node-version: 12 |
There was a problem hiding this comment.
Is there anything that stops us from going with v14? It looks like v12 will be maintained for only 3 more months, according to this.
There was a problem hiding this comment.
The short answer is "I don't know" 😆 so I'd rather have a gentler bump to 12 and see if anything explodes and then revisit to 14 later.
quietbits
approved these changes
Jan 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the minimum tested version of Node to 12 (from an oddly-specific v10.x.y) and upgrades Karma (a developer dependency), which should make many dependabot complaints go away.