Stop re-creating EventSource
s upon receiving a close
event
#772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #567. In that PR, the SDK was updated to handle the
event: close
event as well as recreate theEventSource
object when the event occurred to keep the stream open.However, according to the MDN documentation on server-side events:
Now, it's unclear if the above became spec'd behavior after #567 or not, but the point is, it appears we no longer need to recreate the event stream. Doing so causes test failures such as this one:
This is likely because the call builder is recreating the event stream on the
close
, making itclose
twice.(Adding reviewers from #567.)