Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Modernization #814

Merged
merged 22 commits into from
Apr 13, 2023
Merged

SDK Modernization #814

merged 22 commits into from
Apr 13, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Apr 11, 2023

Epic: #792

Related PR, updating stellar-base: stellar/js-stellar-base#584.

This will have a majority of the same changes, plus some additional ones:

  • dependencies have been updated: axios, eventsource, and bignumber are all at their latest versions
  • GH actions are all updated
  • outdated coveralls stuff dropped
  • weekly downloads badge added

test/unit/federation_server_test.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/liquidity_pool_endpoints_test.js Fixed Show fixed Hide fixed
test/unit/server/join_test.js Fixed Show fixed Hide fixed
test/unit/server_transaction_test.js Fixed Show fixed Hide fixed
test/unit/federation_server_test.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/server/claimable_balances.js Fixed Show fixed Hide fixed
test/unit/server/join_test.js Fixed Show fixed Hide fixed
Fixup the test suite, plus prettier change

Fixups and upgrades to GHA scripts
@Shaptic Shaptic changed the title [DRAFT] SDK Modernization SDK Modernization Apr 11, 2023
Copy link
Contributor

@quietbits quietbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I'm no expert in SDK config 😅, but these updates look good to me.

package.json Outdated Show resolved Hide resolved
Copy link

@aristidesstaffieri aristidesstaffieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I did a quick test drive by symlinking this and found no issues in Freighter.

src/call_builder.ts Outdated Show resolved Hide resolved
@Shaptic Shaptic merged commit 6517b4b into master Apr 13, 2023
@Shaptic Shaptic deleted the modernize branch April 13, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants