Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dependency management #825

Merged
merged 1 commit into from
May 16, 2023
Merged

Improve dependency management #825

merged 1 commit into from
May 16, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented May 15, 2023

This makes a few changes that should decrease bundle size:

  • moves Typescript-related dependencies into the devDependencies section
  • drops polyfills that aren't necessary for the package
  • upgrade stellar-base to its latest beta

Design Question: There's a sentiment in the JavaScript community that "libraries shouldn't do their own polyfills," as different downstream systems can choose to handle this differently. Should we stop polyfilling entirely and just provide documentation / recommendations?

@aristidesstaffieri
Copy link

aristidesstaffieri commented May 16, 2023

Design Question: There's a sentiment in the JavaScript community that "libraries shouldn't do their own polyfills," as different downstream systems can choose to handle this differently. Should we stop polyfilling entirely and just provide documentation / recommendations?

I see both often enough, I think it's a nice out of the box experience to not have to think about the differences but maybe in some cases(like crypto?) it would be nice to be able to swap in a different polyfill. I think in the case of http/https the dx is nice to just have those provided.

@Shaptic Shaptic merged commit 5613dca into master May 16, 2023
@Shaptic Shaptic deleted the depManips branch May 16, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants