Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the unnecessary networkPassphrase parameter #870

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 23, 2023

The network passphrase is part of the transaction object we've been passing around, so there's no need for an explicit networkPassphrase parameter and/or unnecessary getNetwork call.

@Shaptic Shaptic requested a review from sreuland October 23, 2023 22:57
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Size Change: -6.38 kB (0%)

Total Size: 12.1 MB

Filename Size Change
dist/stellar-sdk.js 6.96 MB -4.2 kB (0%)
dist/stellar-sdk.min.js 5.1 MB -2.18 kB (0%)

compressed-size-action

Copy link

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, for consistency, could also remove the js doc param referring to passphrase on assembleTransaction

@Shaptic
Copy link
Contributor Author

Shaptic commented Oct 24, 2023

great catch! fixed :shipit:

@Shaptic Shaptic merged commit 2891ee1 into master Oct 24, 2023
7 checks passed
@Shaptic Shaptic deleted the rpc-no-passphrase branch October 24, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants