-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ContractSpec): add jsonSchema method #889
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Also add tests that generate input data based on JSON schema
2585946
to
f292283
Compare
f292283
to
82d8c5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coupla minor comments, and this might need a yarn fmt
, but this is an awesome feature addition! 👏
(ooh can you add a changelog entry as well?)
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Thanks for the feedback there was a lot of cleanup to do. Is it okay that jsonschema-faker is a dev dep? |
@SocketSecurity ignore jsonpath-plus@7.2.0 |
Replaces js-soroban-client.
Example of proposed schema using custom types contract from CLI
Also add tests that generate input data based on JSON schema