Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource leeway parameter when simulating Soroban transactions. #896

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Dec 15, 2023

What

This adds an optional addlResources parameter to the Soroban RPC's simulateTransaction method which lets users specify an additional leeway for CPU instruction usage in their transaction simulation:

interface SimulationResources {
  cpuInstructions: number;
}

Why

The Soroban RPC server introduced this optional feature as part of the (pending) v20.1.0 (see stellar/stellar-cli#1131).

This additionally fixes #895.

@Shaptic Shaptic added this to the Soroban Pubnet Release milestone Dec 15, 2023
@Shaptic Shaptic self-assigned this Dec 15, 2023
Copy link

Size Change: +3.15 kB (0%)

Total Size: 11.4 MB

Filename Size Change
dist/stellar-sdk.js 6.3 MB +1.92 kB (0%)
dist/stellar-sdk.min.js 5.07 MB +1.23 kB (0%)

compressed-size-action

Copy link

@stellarsaur stellarsaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick change! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update simulateTransaction Requests to Send Parameters as Object
2 participants