Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract-client): match CLI's default timeout #956

Merged

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented May 3, 2024

Even 60 seconds, as it was updated to in 2bcbc6a, might be too short if someone is cautiously reviewing the transaction in Freighter, or if they need ot unlock their Ledger and walk through its process.

Five minutes is the same as the CLI. Maybe it's a reasonable standard to adopt?

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

CHANGELOG.md Outdated Show resolved Hide resolved
Even 60 seconds, as it was updated to in
2bcbc6a, might be too short if someone
is cautiously reviewing the transaction in Freighter, or if they need ot
unlock their Ledger and walk through its process.

Five minutes is the same as the CLI. Maybe it's a reasonable standard to
adopt?

This commit also updates utils.ts to use our eslint settings.
@chadoh chadoh force-pushed the feat/contract-client/default-timeout-300s branch from 7a557ac to 3f13473 Compare May 6, 2024 17:52
@Shaptic Shaptic merged commit b4387de into stellar:master May 7, 2024
10 checks passed
@Shaptic Shaptic mentioned this pull request May 7, 2024
@chadoh chadoh deleted the feat/contract-client/default-timeout-300s branch July 30, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants